[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kbuild
Subject:    Aw: Re: [PATCH] xconfig: Search text should have focus after search and reopen
From:       "Peter Kuemmel" <syntheticpp () gmx ! net>
Date:       2014-11-05 6:55:37
Message-ID: trinity-36be2af2-1224-4ba4-941f-3d8373e34039-1415170537264 () 3capp-gmx-bs04
[Download RAW message or body]

Thx for the hints, hope patches are better now.

Peter

> Gesendet: Dienstag, 04. November 2014 um 21:11 Uhr
> Von: "Paul Bolle" <pebolle@tiscali.nl>
> An: "Peter Kümmel" <syntheticpp@gmx.net>
> Cc: linux-kbuild@vger.kernel.org, yann.morin.1998@free.fr
> Betreff: Re: [PATCH] xconfig: Search text should have focus after search and reopen
> 
> On Tue, 2014-11-04 at 11:35 +0100, Peter Kümmel wrote:
> 
> Again, this patch, though smaller that the previous, is not obviously
> trivial. So, could you please add a few lines describing current
> behavior, why it's wrong, and how this patch fixes it? That might
> increase the chance this patch gets some review.
> 
> > Signed-off-by: Peter Kümmel <syntheticpp@gmx.net>
> > ---
> > scripts/kconfig/qconf.cc | 7 +++++++
> > scripts/kconfig/qconf.h  | 1 +
> > 2 files changed, 8 insertions(+)
> > 
> > diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
> > index 9d3b04b..014df76c 100644
> > --- a/scripts/kconfig/qconf.cc
> > +++ b/scripts/kconfig/qconf.cc
> > @@ -1198,6 +1198,7 @@ ConfigSearchWindow::ConfigSearchWindow(ConfigMainWindow* \
> > parent, const char *nam  layout2->addWidget(editField);
> > 	searchButton = new QPushButton(_("Search"), this);
> > 	searchButton->setAutoDefault(FALSE);
> > +	searchButton->setFocusPolicy(Qt::NoFocus);
> > 	connect(searchButton, SIGNAL(clicked()), SLOT(search()));
> > 	layout2->addWidget(searchButton);
> > 	layout1->addLayout(layout2);
> > @@ -1235,6 +1236,11 @@ ConfigSearchWindow::ConfigSearchWindow(ConfigMainWindow* \
> > parent, const char *nam  }
> > }
> > 
> > +void ConfigSearchWindow::setFocusOnLineEdit()
> > +{
> > +	editField->setFocus(Qt::OtherFocusReason);
> > +}
> > +
> > void ConfigSearchWindow::saveSettings(void)
> > {
> > 	if (name()) {
> > @@ -1506,6 +1512,7 @@ void ConfigMainWindow::searchConfig(void)
> > 	if (!searchWindow)
> > 		searchWindow = new ConfigSearchWindow(this, "search");
> > 	searchWindow->show();
> > +	searchWindow->setFocusOnLineEdit();
> > }
> > 
> > void ConfigMainWindow::changeMenu(struct menu *menu)
> > diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
> > index bde0c6b..6f2c4d6 100644
> > --- a/scripts/kconfig/qconf.h
> > +++ b/scripts/kconfig/qconf.h
> > @@ -288,6 +288,7 @@ public:
> > public slots:
> > 	void saveSettings(void);
> > 	void search(void);
> > +	void setFocusOnLineEdit(void);
> > 
> > protected:
> > 	QLineEdit* editField;
> 
> Thanks,
> 
> 
> Paul Bolle
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]