[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-iommu
Subject:    [PATCH 3/3] iommu/tegra: smmu: Move bus_set_iommu after probe for multi arch
From:       nvmarkzhang () gmail ! com (Mark Zhang)
Date:       2012-11-30 5:07:44
Message-ID: 50B83F13.2010806 () gmail ! com
[Download RAW message or body]

On 11/28/2012 09:52 PM, Hiroshi Doyu wrote:
> For a single image to support multiple SoCs(GART/SMMU).
>

To be honest, I didn't get why we need to move "bus_set_iommu" to probe
func. So could you add more words in the commit message?
Same with tegra-gart.c.

Mark
> Reported-by: Arto Merilainen <amerilainen at nvidia.com>
> Signed-off-by: Hiroshi Doyu <hdoyu at nvidia.com>
> ---
>  drivers/iommu/tegra-smmu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c
> index 46f5712..608185b 100644
> --- a/drivers/iommu/tegra-smmu.c
> +++ b/drivers/iommu/tegra-smmu.c
> @@ -1229,6 +1229,7 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>  
>  	smmu_debugfs_create(smmu);
>  	smmu_handle = smmu;
> +	bus_set_iommu(&platform_bus_type, &smmu_iommu_ops);
>  	return 0;
>  }
>  
> @@ -1273,7 +1274,6 @@ static struct platform_driver tegra_smmu_driver = {
>  
>  static int __devinit tegra_smmu_init(void)
>  {
> -	bus_set_iommu(&platform_bus_type, &smmu_iommu_ops);
>  	return platform_driver_register(&tegra_smmu_driver);
>  }
>  
> 

[prev in list] [next in list] [prev in thread] [next in thread]