[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-iommu
Subject:    [PATCH] intel-iommu: Fix use after release during device attach
From:       chrisw () sous-sol ! org (Chris Wright)
Date:       2010-12-10 18:44:02
Message-ID: 20101210184402.GE4040 () sequoia ! sous-sol ! org
[Download RAW message or body]

* Jan Kiszka (jan.kiszka at siemens.com) wrote:
> >>> --- a/drivers/pci/intel-iommu.c
> >>> +++ b/drivers/pci/intel-iommu.c
> >>> @@ -3627,9 +3627,9 @@ static int intel_iommu_attach_device(struct
> >>> iommu_domain *domain,
> >>>
> >>>  		pte = dmar_domain->pgd;
> >>>  		if (dma_pte_present(pte)) {
> >>> -			free_pgtable_page(dmar_domain->pgd);
> >>>  			dmar_domain->pgd = (struct dma_pte *)
> >>>  				phys_to_virt(dma_pte_addr(pte));

While here, might as well remove the unnecessary cast.

> >>> +			free_pgtable_page(pte);
> >>>  		}
> >>>  		dmar_domain->agaw--;
> >>>  	}
> >>
> >> Reviewed-by: Sheng Yang <sheng at linux.intel.com>

Acked-by: Chris Wright <chrisw at sous-sol.org>

> >> CC iommu mailing list and David.
> > 
> > Ping...
> > 
> > I think this fix also qualifies for stable (.35 and .36).
> > 
> 
> Still not merged?

David, do you plan to pick this one up?

thanks,
-chris

[prev in list] [next in list] [prev in thread] [next in thread]