[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-integrity
Subject:    Re: [PATCH v6 4/8] tpm: Update struct tpm_buf documentation comments
From:       "Jarkko Sakkinen" <jarkko () kernel ! org>
Date:       2023-12-04 2:40:24
Message-ID: CXF7A8PSEKNX.SM7LV367AYHW () suppilovahvero
[Download RAW message or body]

On Mon Nov 27, 2023 at 10:41 PM EET, Stefan Berger wrote:
>
>
> On 11/23/23 21:02, Jarkko Sakkinen wrote:
> > Remove deprecated portions and document enum values.
> > 
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > ---
> > v1 [2023-11-21]: A new patch.
> > v2 [2023-11-24]: Refined the commit message a bit.
> > ---
> >   include/linux/tpm.h | 9 ++++-----
> >   1 file changed, 4 insertions(+), 5 deletions(-)
> > 
> > diff --git a/include/linux/tpm.h b/include/linux/tpm.h
> > index bb0e8718a432..0a8c1351adc2 100644
> > --- a/include/linux/tpm.h
> > +++ b/include/linux/tpm.h
> > @@ -297,15 +297,14 @@ struct tpm_header {
> >   	};
> >   } __packed;
> >   
> > -/* A string buffer type for constructing TPM commands. This is based on the
> > - * ideas of string buffer code in security/keys/trusted.h but is heap based
> > - * in order to keep the stack usage minimal.
> > - */
> > -
> >   enum tpm_buf_flags {
> > +	/* the capacity exceeded: */
>
> was exceeded

+1, agreed a better form :-)

>
> >   	TPM_BUF_OVERFLOW	= BIT(0),
> >   };
> >   
> > +/*
> > + * A string buffer type for constructing TPM commands.
> > + */
> >   struct tpm_buf {
> >   	unsigned int flags;
> >   	u8 *data;
>
> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

If possible give this to the James' patch set, thank you for the review.

BR, Jarkko

[prev in list] [next in list] [prev in thread] [next in thread]