[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-input
Subject:    Re: [PATCH v6 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller
From:       Rob Herring <robh () kernel ! org>
Date:       2022-02-28 2:44:30
Message-ID: 1646016270.948219.47199.nullmailer () robh ! at ! kernel ! org
[Download RAW message or body]

On Sun, 27 Feb 2022 22:33:16 +1000, Alistair Francis wrote:
> Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings
> documentation. It can use I2C or SPI bus.
> This touchscreen can handle some defined zone that are designed and
> sent as button. To be able to customize the keycode sent, the
> "linux,code" property in a "button" sub-node can be used.
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../input/touchscreen/cypress,tt21000.yaml    | 98 +++++++++++++++++++
> 1 file changed, 98 insertions(+)
> create mode 100644 \
> Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:38.21-31: \
Warning (reg_format): /example-0/i2c/touchscreen@24/button@0:reg: property has \
invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:43.21-31: \
Warning (reg_format): /example-0/i2c/touchscreen@24/button@1:reg: property has \
invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:48.21-31: \
Warning (reg_format): /example-0/i2c/touchscreen@24/button@2:reg: property has \
invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dt.yaml: \
Warning (pci_device_reg): Failed prerequisite 'reg_format' \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dt.yaml: \
Warning (pci_device_bus_num): Failed prerequisite 'reg_format' \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dt.yaml: \
Warning (simple_bus_reg): Failed prerequisite 'reg_format' \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dt.yaml: \
Warning (i2c_bus_reg): Failed prerequisite 'reg_format' \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dt.yaml: \
Warning (spi_bus_reg): Failed prerequisite 'reg_format' \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:37.26-40.19: \
Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@24/button@0: Relying on \
default #address-cells value \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:37.26-40.19: \
Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@24/button@0: Relying on \
default #size-cells value \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:42.26-45.19: \
Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@24/button@1: Relying on \
default #address-cells value \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:42.26-45.19: \
Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@24/button@1: Relying on \
default #size-cells value \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:47.26-50.19: \
Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@24/button@2: Relying on \
default #address-cells value \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dts:47.26-50.19: \
Warning (avoid_default_addr_size): /example-0/i2c/touchscreen@24/button@2: Relying on \
default #size-cells value \
Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.example.dt.yaml: \
Warning (unique_unit_address_if_enabled): Failed prerequisite \
'avoid_default_addr_size'

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1598249

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


[prev in list] [next in list] [prev in thread] [next in thread]