[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-input
Subject:    Re: [PATCH v4 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using HID framework
From:       Andy Shevchenko <andy.shevchenko () gmail ! com>
Date:       2020-03-31 17:24:59
Message-ID: CAHp75Vfr6q_H6z6tRFfaKedF7oR7nhmZvRWL4mxx3W7uypUFvA () mail ! gmail ! com
[Download RAW message or body]

On Tue, Mar 31, 2020 at 4:26 PM Shah, Nehal-bakulchandra
<nehal-bakulchandra.shah@amd.com> wrote:
> On 3/31/2020 6:01 PM, Richard Neumann wrote:
> > Not a real review, but your patch series seems to be repeating a lot
> > from drivers/i2c/busses/i2c-amd-mp2*.
> > Is there any chance we could re-use the code?
> > E.g. the AMD_C2P_* definitions from drivers/i2c/busses/i2c-amd-mp2.h?
> 
> Thanks for the mail. Yes there are some common structures, however as of now we \
> have kept separately considering both 
> are part of different sub systems. But may be will consider this input for future \
> enhancement.

It can be done in a form of shared definitions at least in
include/linux/platform_data/x86/amd-mp2.h or alike ...

-- 
With Best Regards,
Andy Shevchenko


[prev in list] [next in list] [prev in thread] [next in thread]