[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-input
Subject:    Re: [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block
From:       Benjamin Tissoires <benjamin.tissoires () redhat ! com>
Date:       2017-11-27 8:18:20
Message-ID: 20171127081820.GC30708 () mail ! corp ! redhat ! com
[Download RAW message or body]

On Nov 26 2017 or thereabouts, Daniel Axtens wrote:
> If you compile with:
> CONFIG_HID_HOLTEK=m
> CONFIG_HOLTEK_FF is not set
> 
> You get the following warning:
> WARNING: modpost: missing MODULE_LICENSE() in drivers/hid/hid-holtekff.o
> see include/linux/module.h for more information
> 
> Fix this by moving the module info out of the #ifdef CONFIG_HOLTEK_FF
> block and into the un-guarded part of the file.
> 
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> ---

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

>  drivers/hid/hid-holtekff.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
> index 9325545fc3ae..edc0f64bb584 100644
> --- a/drivers/hid/hid-holtekff.c
> +++ b/drivers/hid/hid-holtekff.c
> @@ -32,10 +32,6 @@
>  
>  #ifdef CONFIG_HOLTEK_FF
>  
> -MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
> -MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices");
> -
>  /*
>   * These commands and parameters are currently known:
>   *
> @@ -223,3 +219,7 @@ static struct hid_driver holtek_driver = {
>  	.probe = holtek_probe,
>  };
>  module_hid_driver(holtek_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
> +MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices");
> -- 
> 2.11.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]