[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-input
Subject:    Re: [PATCH 2/2] input: wacom - Bamboo One 1024 pressure fix
From:       Ping Cheng <pinglinux () gmail ! com>
Date:       2012-05-22 17:42:44
Message-ID: CAF8JNhLCeS3w9ST4=waLOz1y4TPD_LM4F9dnAVe3TDYhv6txhg () mail ! gmail ! com
[Download RAW message or body]

On Sun, May 20, 2012 at 6:43 PM,  <chris@cnpbagwell.com> wrote:
> From: Chris Bagwell <chris@cnpbagwell.com>
>
> Bamboo One's with ID of 0x6a and 0x6b were added with correct
> indication of 1024 pressure levels but the Graphire packet routine
> was only looking at 9 bits.  Increased to 10 bits.
>
> This bug caused these devices to roll over to zero pressure at half
> way mark.
>
> The other devices using this routine only support 256 or 512 range
> and look to fix unused bits at zero.
>
> Signed-off-by: Chris Bagwell <chris@cnpbagwell.com>
> Reported-by: Tushant Mirchandani <tushantin@gmail.com>

Reviewed-by: Ping Cheng <pingc@wacom.com>

Ping

> ---
>  drivers/input/tablet/wacom_wac.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index 004bc1b..869e057 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -248,7 +248,7 @@ static int wacom_graphire_irq(struct wacom_wac *wacom)
>                input_report_abs(input, ABS_X, le16_to_cpup((__le16 *)&data[2]));
>                input_report_abs(input, ABS_Y, le16_to_cpup((__le16 *)&data[4]));
>                if (wacom->tool[0] != BTN_TOOL_MOUSE) {
> -                       input_report_abs(input, ABS_PRESSURE, data[6] | ((data[7] & 0x01) << 8));
> +                       input_report_abs(input, ABS_PRESSURE, data[6] | ((data[7] & 0x03) << 8));
>                        input_report_key(input, BTN_TOUCH, data[1] & 0x01);
>                        input_report_key(input, BTN_STYLUS, data[1] & 0x02);
>                        input_report_key(input, BTN_STYLUS2, data[1] & 0x04);
> --
> 1.7.10.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]