[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-iio
Subject:    Re: [PATCH v3 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers
From:       Sean Nyekjaer <sean () geanix ! com>
Date:       2021-04-29 5:53:35
Message-ID: b1529522-6fc9-ad01-e05c-5b8d4c8364f1 () geanix ! com
[Download RAW message or body]



On 28/04/2021 16.19, Jonathan Cameron wrote:
>> +static int fxls8962af_get_temp(struct fxls8962af_data *data, int *val)
>> +{
>> +	struct device *dev = regmap_get_device(data->regmap);
>> +	unsigned int value;
>> +	int ret;
>> +
>> +	ret = fxls8962af_drdy(data);
> I'm a little confused.  You check data is ready before calling power on
> which could result in you moving from standby to active state?
>
>
Reading it again, I would definitively move it around :)
When testing it looks like we currently are getting the last sample from 
active state.

/Sean
[prev in list] [next in list] [prev in thread] [next in thread]