[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-iio
Subject:    Re: [PATCH v3 2/3] dt-bindings: iio: Add cros ec proximity yaml doc
From:       Jonathan Cameron <jic23 () kernel ! org>
Date:       2021-01-31 12:41:38
Message-ID: 20210131124138.740d4f7f () archlinux
[Download RAW message or body]

On Thu, 28 Jan 2021 09:11:32 -0800
Stephen Boyd <swboyd@chromium.org> wrote:

> Quoting Enric Balletbo Serra (2021-01-28 01:44:23)
> > Missatge de Stephen Boyd <swboyd@chromium.org> del dia dj., 28 de gen.
> > 2021 a les 9:45:  
> > > +
> > > +  label:
> > > +    description: Name for proximity sensor
> > > +
> > > +required:
> > > +  - compatible
> > > +
> > > +unevaluatedProperties: false
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > +  - |  
> > 
> > For this kind of devices it is preferred to see a complete example
> > rather than pieces spread around different yaml. This helps proper
> > binding parsing.
> > 
> > spi0 {
> > #address-cells = <1>;
> > #size-cells = <0>;
> > 
> > cros_ec: ec@0 {
> > compatible = "google,cros-ec-spi";
> > reg = <0>;  
> 
> What if it isn't on spi bus though? I'd rather leave it as is and let
> the google,cros-ec.yaml binding indicate that it is a child of the EC
> node.
It's an example. So definitely doesn't rule out other options than spi.

I think I'd also prefer to see the full example here to exercise more
of the relevant bindings when doing tests.

Mind you this is Rob's area, so I'll defer to Rob for preference.
@Rob?
> 
> > 
> > > +    proximity {
> > > +        compatible = "google,cros-ec-mkbp-proximity";
> > > +        label = "proximity-wifi-lte";
> > > +    };
> > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml \
> > > b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml index \
> > >                 76bf16ee27ec..479a9f15de32 100644
> > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> > > @@ -94,6 +94,9 @@ properties:
> > > keyboard-controller:
> > > $ref: "/schemas/input/google,cros-ec-keyb.yaml#"
> > > 
> > > +  proximity:
> > > +    $ref: "/schemas/iio/proximity/google,cros-ec-mkbp-proximity.yaml#"
> > > +
> > > codecs:
> > > type: object
> > > additionalProperties: false  


[prev in list] [next in list] [prev in thread] [next in thread]