[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-iio
Subject:    Re: [PATCH 2/3 v3] iio: adc: break out common code from SPMI VADC
From:       Jonathan Cameron <jic23 () kernel ! org>
Date:       2017-01-30 20:11:43
Message-ID: a28bbe67-8334-5d14-029e-5c4ec181586f () kernel ! org
[Download RAW message or body]

On 30/01/17 09:15, Linus Walleij wrote:
> On Sat, Jan 21, 2017 at 2:37 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 17/01/17 14:25, Linus Walleij wrote:
>>> The SPMI VADC and the earlier XOADC share a subset of
>>> common code, so to be able to use the same code in both
>>> drivers, we break out a separate file with the common code,
>>> prefix exported functions that are no longer static with
>>> qcom_* and bake an object qcom-vadc.o that contains both
>>> files: qcom-vadc-common.o and qcom-spmi-vadc.o.
>>>
>>> Cc: linux-arm-kernel@lists.infradead.org
>>> Cc: linux-arm-msm@vger.kernel.org
>>> Cc: Ivan T. Ivanov <iivanov.xz@gmail.com>
>>> Cc: Andy Gross <andy.gross@linaro.org>
>>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>>> Cc: Stephen Boyd <sboyd@codeaurora.org>
>>> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>> Cc: Rama Krishna Phani A <rphani@codeaurora.org>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> This looks like fairly straight forward refacting to me.  Rama, could you
>> take a look at this and perhaps test that no breakage has slipped in?
>>
>> I'd like at least one tested-by on this for the previously supported parts
>> (that could be Linus if he has one!)
> 
> I am waiting for a serial cable for the APQ8064 Nexus 7 so no
> test base so far. I would have to rely on Björn for this.
> 
> I think this patch is safe to merge though.
Fair enough. Applied to the togreg branch of iio.git and pushed out
as testing for the autobuilders to play with it.

Thanks,


Jonathan

> 
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]