[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ide
Subject:    Re: [PATCH] ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command
From:       Tejun Heo <tj () kernel ! org>
Date:       2018-01-25 15:31:15
Message-ID: 20180125153115.GF17457 () devbig577 ! frc2 ! facebook ! com
[Download RAW message or body]

On Thu, Jan 25, 2018 at 06:32:59PM +0800, Jia-Ju Bai wrote:
> After checking all possible call chains to it821x_firmware_command here,
> my tool finds that it821x_firmware_command 
> is never called in atomic context,
> namely never in an interrupt handler or holding a spinlock.
> And it821x_firmware_command calls kmalloc(GFP_KERNEL), 
> so it proves again that it821x_firmware_command 
> can call functions which can sleep.
> Thus mdelay can be replaced with usleep_range to avoid busy wait.
> 
> This is found by a static analysis tool named DCNS written by myself.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>

Applied to libata/for-4.16.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]