[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ide
Subject:    Re: [PATCH 1/1] libata: Fix ATA request sense
From:       Sergei Shtylyov <sergei.shtylyov () cogentembedded ! com>
Date:       2016-12-20 10:22:58
Message-ID: 2325edac-26c8-ac0e-20d3-80d26f4bb642 () cogentembedded ! com
[Download RAW message or body]

On 12/20/2016 5:25 AM, Damien Le Moal wrote:

>>> For an ATA device supporting the sense data reporting feature set,
>>> a failed command will trigger the execution of ata_eh_request_sense if
>>> the result task file of the failed command has the ATA_SENSE bit set
>>> (sense data available bit). ata_eh_request_sense executes the
>>> REQUEST SENSE DATA EXT command to retrieve the sense data of the failed
>>> command. On success of REQUEST SENSE DATA EXT, the ATA_SENSE bit will
>>> NOT be set (the command succeeded) but ata_eh_request_sense
>>> nevertheless tests the availability of sense data by testing that bit
>>> presence in the result tf of the REQUEST SENSE DATA EXT command.
>>> This leads to a falsy assume that request sense data failed and to the
>>
>>     False assumption?
>
> "This leads to falsely assume that..."

    "Leads us to falsely assume" then, maybe?

> My apologies for the typo.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]