[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ide
Subject:    Re: [PATCH 4.2] ata: ahci_brcmstb: Fix warnings with CONFIG_PM_SLEEP=n
From:       Tejun Heo <tj () kernel ! org>
Date:       2015-07-28 18:02:59
Message-ID: 20150728180259.GK5322 () mtj ! duckdns ! org
[Download RAW message or body]

On Mon, Jul 27, 2015 at 12:54:07PM -0700, Florian Fainelli wrote:
> On 14/07/15 15:06, Brian Norris wrote:
> > On Tue, Jul 14, 2015 at 01:03:33PM -0700, Florian Fainelli wrote:
> >> When CONFIG_PM_SLEEP is disabled, brcm_ahci_{suspend,resume} are not
> >> used, which causes such a build warning to occur:
> >>
> >>   CC      drivers/ata/ahci_brcmstb.o
> >> drivers/ata/ahci_brcmstb.c:212:12: warning: 'brcm_ahci_suspend' defined
> >> but not used [-Wunused-function]
> >>  static int brcm_ahci_suspend(struct device *dev)
> >>             ^
> >> drivers/ata/ahci_brcmstb.c:224:12: warning: 'brcm_ahci_resume' defined
> >> but not used [-Wunused-function]
> >>  static int brcm_ahci_resume(struct device *dev)
> >>             ^
> >>   LD      drivers/ata/built-in.o
> >>
> >> Fixes: 766a2d979632 ("ata: add Broadcom AHCI SATA3 driver for STB chips")
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> Tejun, this is a new driver that got merged during 4.2, could you queue
> >> this up for an upcoming 4.2-rcX pull request?
> > 
> > Acked-by: Brian Norris <computersforpeace@gmail.com>
> > 
> 
> Tejun, I am not seeing this change queued in your for-4.2-fixes branch
> did you need me to do anything?

Oops, I missed it, sorry.  Applied to libata/for-4.2-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]