[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ide
Subject:    Re: [PATCH] sata_sil: fix uninitialized variable use when
From:       Yoichi Yuasa <yuasa () linux-mips ! org>
Date:       2009-10-27 1:37:49
Message-ID: 20091027103749.871199e8.yuasa () linux-mips ! org
[Download RAW message or body]

On Mon, 26 Oct 2009 16:12:43 +0100
Tejun Heo <tj@kernel.org> wrote:

> Yuasa Yoichi wrote:
> >> The first usage of that is
> >>
> >>  sil_scr_read(&ap->link, SCR_ERROR, &serror);
> >>
> >> which sets the value.  So, I don't think the patch is necessary.  If
> >> it triggers a compile warning, putting uninitialized_var() macro will
> >> be more appropriate.
> > 
> > If sil_scr_read() is error, 'serror' is not initialized.
> > After that, the wrong bits add to 'ap->link.eh_info.serror' when
> > 'serror & SERR_PHYRDT_CHG' is true.
> 
> On the controller, sil_scr_read(SCR_ERROR) can never fail.  If it ever
> fails, the whole thing will break anyway.

OK, I got it.

Thanks,

Yoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]