[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ide
Subject:    Re: [PATCH] libata: clear TF before IDENTIFYing
From:       "Art Haas" <ahaas () airmail ! net>
Date:       2007-02-13 19:38:50
Message-ID: 20070213193850.GA23600 () artsapartment ! org
[Download RAW message or body]

On Wed, Feb 07, 2007 at 12:37:41PM -0800, Tejun Heo wrote:
> Some devices chock if Feature is not clear when IDENTIFY is issued.
> Set ATA_TFLAG_ISADDR | ATA_TFLAG_DEVICE for IDENTIFY such that whole
> TF is cleared when reading ID data.
> 
> Kudos to Art Haas for testing various futile patches over several
> months and Mark Lord for pointing out the fix.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Art Haas <ahaas@airmail.net>
> Cc: Mark Lord <mlord@pobox.com>
> ---
> I think this should go into -stable but a little bit hesitant because
> the code hasn't been tested widely.  This patch should really be
> harmless but who knows.  Jeff, Mark, what do you think?
> 
> [ ... snip patch ... ]

Hi.

I applied this patch for a kernel build on another PIIX based machine
around here, plus the 'ata_piix.c' patch that was tested earlier, and
the patched kernel booted without problems. I'm guessing that between
the time the patch was initially posted and now other people have tried
it out, but I can confirm the patches did not cause problems on the
machine (SMP PIII box).

A little more testing info for those wanting some results. The kernel,
btw, was Linus' git tree from this morning.

Art Haas
-- 
Man once surrendering his reason, has no remaining guard against absurdities
the most monstrous, and like a ship without rudder, is the sport of every wind.

-Thomas Jefferson to James Smith, 1822
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]