[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ide
Subject:    Re: 2.6.20-rc6: known unfixed regressions (v2) (part 2)
From:       Linus Torvalds <torvalds () linux-foundation ! org>
Date:       2007-01-30 4:44:33
Message-ID: Pine.LNX.4.64.0701292034470.3611 () woody ! linux-foundation ! org
[Download RAW message or body]



On Mon, 29 Jan 2007, Mike Christie wrote:
> 
> Ok. here is a fix with the overflow check sg.c has. Patch
> was made against Linus's tree and tested with nero.
> 
> Userspace does not send us jiffies. Use msecs_to_jiffies
> and check for overflow like sg.c
> 
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>

Thanks. Fixed the ',' that Andrew pointed out, committed and pushed out.

What a stupid bug. And I even _looked_ at that patch, since there weren't 
that many that changed anything in this area, and it looked just subtly 
right enough that no warning bells ever went off.

Thanks to everybody, but especially Mike for showing us the errors of our 
ways.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]