[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-ide
Subject: Re: [PATCH] libata-dev-2.6-ncq: do ata_qc_new inside host_set lock
From: Jeff Garzik <jgarzik () pobox ! com>
Date: 2005-06-26 17:25:08
Message-ID: 42BEE4F4.90901 () pobox ! com
[Download RAW message or body]
Tejun Heo wrote:
> Hello, Jeff.
> Hello, Jens.
>
> This is the third of six misc updates to ncq.
>
> ata_qc_new() used to use atomic test_and_set_bit() to allocate qc.
> This makes grabbing host_set lock before calling ata_qc_new_init()
> unncessary, but in most cases (normal SCSI requests) we're holding the
> lock on entry anyway, so the optimization just adds expensive atomic
> bitops. This patch makes qc allocation performed inside host_set lock
> and uses ffz() instead of atomic bitops.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
hmmmm, I rather liked the old way. I'll give this one some thought.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic