[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ide
Subject:    Re: [PATCH] kmalloc old_hwif
From:       Danny Cox <Danny.Cox () ECWeb ! com>
Date:       2004-05-21 18:55:19
Message-ID: 1085165718.833.83.camel () vom
[Download RAW message or body]

Bartlomiej,

On Fri, 2004-05-21 at 14:39, Bartlomiej Zolnierkiewicz wrote:
> You do 'goto abort' while not holding locks.

	Yes, you're correct.  Should I be holding the locks?  I didn't think
that you'd want to call kmalloc() with GFP_KERNEL inside a spinlock
because it might sleep.  So, I moved the kmalloc() to be one of the
first things done to avoid being inside the lock(s).  The comment at the
top of the function is correct: it IS bonkers!

> Anyway this is the minor issue,
> the major issue is that...  you are late 52 hours... ;-)
> 
> Similar patch from Chris Wedgwood has been merged recently.

	Cool!  Like I said, I mainly wanted to get some form of this idea into
ide_unregister().

	Thanks!

-- 
Daniel S. Cox
Electronic Commerce Systems

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]