[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ia64
Subject:    Re: [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls
From:       Andy Shevchenko <andriy.shevchenko () linux ! intel ! com>
Date:       2019-04-30 14:10:29
Message-ID: 20190430141029.GK9224 () smile ! fi ! intel ! com
[Download RAW message or body]

On Mon, Apr 29, 2019 at 05:59:04PM +0200, Christophe Leroy wrote:
> Le 27/04/2019 à 14:52, Enrico Weigelt, metux IT consult a écrit :
> > Fix checkpatch warnings by using pr_err():
> > 
> > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, \
> > ... then pr_err(...  to printk(KERN_ERR ... #109: FILE: \
> > drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c:109: +		printk(KERN_ERR
> > 
> > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, \
> > ... then pr_err(...  to printk(KERN_ERR ... #128: FILE: \
> > drivers/tty/serial/cpm_uart/cpm_uart_cpm2.c:128: +		printk(KERN_ERR
> > 
> > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, \
> > ... then pr_err(...  to printk(KERN_ERR ... +           printk(KERN_ERR
> > 
> > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, \
> > ... then pr_err(...  to printk(KERN_ERR ... +           printk(KERN_ERR
> > 
> > Signed-off-by: Enrico Weigelt <info@metux.net>
> 
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> 
> But is that really worth doing those changes ?
> 
> If we want to do something useful, wouldn't it make more sense to introduce
> the use of dev_err() in order to identify the faulting device in the message
> ?

+1 for switching to dev_*().

-- 
With Best Regards,
Andy Shevchenko


[prev in list] [next in list] [prev in thread] [next in thread]