[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver
From:       Viresh Kumar <viresh.kumar () linaro ! org>
Date:       2021-06-30 15:21:01
Message-ID: 20210630150901.5uzjelg4k7xgbumb () vireshk-i7
[Download RAW message or body]

On 30-06-21, 16:38, Wolfram Sang wrote:
> > While we are at it, this has been replaced by a Rust counterpart [1]
> > (as that makes it hypervisor agnostic, which is the goal of my work
> > here) and I need someone with I2C knowledge to help review it. It
> > should be okay even if you don't understand Rust a lot, just review
> > this file[2] which is where most of i2c specific stuff lies.
> 
> From the high level review I can provide, it looks good to me. Block
> transfers are missing, but I think you said that already. Mising Rust
> experience, I might miss details, of course. But the general approach
> seems fine to me. smbus_prepare() will get a bit more messy when you add
> block transfers, but it still looks bearable, I think.

Thanks for having a look.

-- 
viresh
[prev in list] [next in list] [prev in thread] [next in thread]