[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [PATCH RFT] i2c: brcmstb: properly check NACK condition
From:       Wolfram Sang <wsa () the-dreams ! de>
Date:       2020-04-28 22:09:04
Message-ID: 20200428220904.GB7698 () kunai
[Download RAW message or body]


On Sun, Apr 26, 2020 at 10:12:10AM +0200, Wolfram Sang wrote:
> From: Wolfram Sang <wsa@the-dreams.de>
> 
> cppcheck rightfully complains about:
> 
> drivers/i2c/busses/i2c-brcmstb.c:319:7: warning: Condition 'CMD_RD' is always true \
> [knownConditionTrueFalse] drivers/i2c/busses/i2c-brcmstb.c:319:17: warning: \
> Condition 'CMD_WR' is always false [knownConditionTrueFalse] if ((CMD_RD || CMD_WR) \
> && 
> Compare the values to the 'cmd' variable.
> 
> Fixes: dd1aa2524bc5 ("i2c: brcmstb: Add Broadcom settop SoC i2c controller driver")
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

Applied to for-current, thanks!


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]