[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [PATCH] i2c: designware: make use of devm_gpiod_get_optional
From:       Jarkko Nikula <jarkko.nikula () linux ! intel ! com>
Date:       2019-07-29 13:27:49
Message-ID: d183839e-09e0-1a97-58f1-dace016c1f43 () linux ! intel ! com
[Download RAW message or body]

On 7/25/19 11:39 PM, Andy Shevchenko wrote:
> On Thu, Jul 25, 2019 at 10:21:36PM +0200, Uwe Kleine-König wrote:
>> There is a semantical change: if devm_gpiod_get_optional returns -ENOSYS
>> this is passed as error to the caller. This effectively reverts commit
>> d1fa74520dcd ("i2c: designware: Consider SCL GPIO optional") which
>> shouldn't be necessary any more since gpiod_get_optional doesn't return
>> -ENOSYS any more with GPIOLIB=n.
> 
> I like this!
> Thanks and take mine
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
[prev in list] [next in list] [prev in thread] [next in thread]