[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    RE: REGRESSION: i2c-imx endlessly triggers clk warning
From:       Aisheng Dong <aisheng.dong () nxp ! com>
Date:       2019-07-29 11:28:52
Message-ID: AM0PR04MB4211E3811826ADCA85F0FD0280DD0 () AM0PR04MB4211 ! eurprd04 ! prod ! outlook ! com
[Download RAW message or body]

> From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
> Sent: Monday, July 29, 2019 7:17 PM
> 
> Booting 5.2 on the VF610 based ZII rev B board results in the board not making
> progress due to an endless stream of:
> 

Thanks for the reporting.

> [  153.077831] ------------[ cut here ]------------ [  153.082528] WARNING: CPU:
> 0 PID: 15 at drivers/clk/clk.c:924 clk_core_disable_lock+0x18/0x24
> [  153.093077] i2c0 already disabled [  153.096416] Modules linked in:
> [  153.099521] CPU: 0 PID: 15 Comm: kworker/0:1 Tainted: G        W
> 5.2.0+ #321
> [  153.107290] Hardware name: Freescale Vybrid VF5xx/VF6xx (Device Tree)
> [  153.113772] Workqueue: events deferred_probe_work_func
> [  153.118979] [<c0019560>] (unwind_backtrace) from [<c0014734>]
> (show_stack+0x10/0x14) [  153.126778] [<c0014734>] (show_stack) from
> [<c083f8dc>] (dump_stack+0x9c/0xd4) [  153.134051] [<c083f8dc>]
> (dump_stack) from [<c0031154>] (__warn+0xf8/0x124) [  153.141056]
> [<c0031154>] (__warn) from [<c0031248>] (warn_slowpath_fmt+0x38/0x48)
> [  153.148580] [<c0031248>] (warn_slowpath_fmt) from [<c040fde0>]
> (clk_core_disable_lock+0x18/0x24) [  153.157413] [<c040fde0>]
> (clk_core_disable_lock) from [<c058f520>] (i2c_imx_probe+0x554/0x6ec)
> [  153.166076] [<c058f520>] (i2c_imx_probe) from [<c04b9178>]
> (platform_drv_probe+0x48/0x98) [  153.174297] [<c04b9178>]
> (platform_drv_probe) from [<c04b7298>] (really_probe+0x1d8/0x2c0)
> [  153.182605] [<c04b7298>] (really_probe) from [<c04b7554>]
> (driver_probe_device+0x5c/0x174) [  153.190909] [<c04b7554>]
> (driver_probe_device) from [<c04b58c8>] (bus_for_each_drv+0x44/0x8c)
> [  153.199480] [<c04b58c8>] (bus_for_each_drv) from [<c04b746c>]
> (__device_attach+0xa0/0x108) [  153.207782] [<c04b746c>] (__device_attach)
> from [<c04b65a4>] (bus_probe_device+0x88/0x90) [  153.215999]
> [<c04b65a4>] (bus_probe_device) from [<c04b6a04>]
> (deferred_probe_work_func+0x60/0x90)
> [  153.225003] [<c04b6a04>] (deferred_probe_work_func) from [<c004f190>]
> (process_one_work+0x204/0x634) [  153.234178] [<c004f190>]
> (process_one_work) from [<c004f618>] (worker_thread+0x20/0x484)
> [  153.242315] [<c004f618>] (worker_thread) from [<c0055c2c>]
> (kthread+0x118/0x150) [  153.249758] [<c0055c2c>] (kthread) from
> [<c00090b4>] (ret_from_fork+0x14/0x20) [  153.257006] Exception
> stack(0xdde43fb0 to 0xdde43ff8)
> [  153.262095] 3fa0:                                     00000000
> 00000000 00000000 00000000
> [  153.270306] 3fc0: 00000000 00000000 00000000 00000000 00000000
> 00000000 00000000 00000000 [  153.278520] 3fe0: 00000000 00000000
> 00000000 00000000 00000013 00000000 [  153.285159] irq event stamp:
> 3323022 [  153.288787] hardirqs last  enabled at (3323021): [<c0861c4c>]
> _raw_spin_unlock_irq+0x24/0x2c [  153.297261] hardirqs last disabled at
> (3323022): [<c040d7a0>] clk_enable_lock+0x10/0x124 [  153.305392]
> softirqs last  enabled at (3322092): [<c000a504>] __do_softirq+0x344/0x540
> [  153.313352] softirqs last disabled at (3322081): [<c00385c0>]
> irq_exit+0x10c/0x128 [  153.320946] ---[ end trace a506731ccd9bd703 ]---
> 
> My guess is that this is due to a combination of e1ab9a468e3b ("i2c:
> imx: improve the error handling in i2c_imx_dma_request()") and the fact that
> my configuration has CONFIG_FSL_EDMA=m.  Given that the boot makes no
> progress, it seems that this driver now requires EDMA to be built-in _if_ this
> driver is also built in.  It seems that Kconfig allows an invalid configuration as
> far as the driver is concerned.
> 
> However, even though it seems that EDMA needs to be built-in with 5.2, this
> should not trigger the above kernel warning, which suggests something is
> wrong in the driver cleanup paths.

Copy Yibin to check the possible edma issue.

Regards
Aisheng

> 
> --
> RMK's Patch system:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ar
> mlinux.org.uk%2Fdeveloper%2Fpatches%2F&amp;data=02%7C01%7Caisheng.
> dong%40nxp.com%7Ce3e704d7d9414e860c7a08d714165ebc%7C686ea1d3b
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C636999958630559001&amp;sdata
> =2d2Ti0gMN2vi7n4hPrsPZ2jGw3kqScStqPzpI%2BiEOXY%3D&amp;reserved=0
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps
> up According to speedtest.net: 11.9Mbps down 500kbps up

[prev in list] [next in list] [prev in thread] [next in thread]