[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
From:       Vignesh R <vigneshr () ti ! com>
Date:       2018-09-28 5:39:18
Message-ID: 3943f2b1-3850-ad1e-6318-cfaec0eff485 () ti ! com
[Download RAW message or body]



On Wednesday 26 September 2018 08:14 PM, Peter Rosin wrote:
> On 2018-09-26 13:57, Vignesh R wrote:
> > AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
> > handle AM654 SoCs.
> > 
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
> > Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt \
> > b/Documentation/devicetree/bindings/i2c/i2c-omap.txt index \
> >                 7e49839d4124..11ce869d682d 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
> > @@ -2,7 +2,8 @@ I2C for OMAP platforms
> > 
> > Required properties :
> > - compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
> > -  or "ti,omap4-i2c"
> > +  or "ti,omap4-i2c" for OMAP2+ SoCs
> > +- compatible : Must "ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
> ^
> be
> 
> Also, it looks bad with two 'compatible' entries in the properties list.
> I think the trend is to list one valid compatible (plus fallbacks)
> per line. So, you should consider reformatting, possibly like so:
> 
> - compatible : Must be one of
> 	"ti,omap2420-i2c"
> 	"ti,omap2430-i2c"
> 	"ti,omap3-i2c"
> "ti,omap4-i2c"
> 	"ti,am654-i2c", "ti,omap4-i2c"
> 

I have sent v2 with these changes. Thanks for the review!


-- 
Regards
Vignesh


[prev in list] [next in list] [prev in thread] [next in thread]