[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-i2c
Subject: Re: [PATCH] i2c: piix4: Fix request_region size
From: Jean Delvare <jdelvare () suse ! de>
Date: 2017-01-31 13:42:15
Message-ID: 20170131144215.470703ae () endymion
[Download RAW message or body]
Hi Ricardo, Wolfram,
On Fri, 27 Jan 2017 15:59:30 +0100, Ricardo Ribalda Delgado wrote:
> Since '701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC")' we
> are using the SMBSLVCNT register at offset 0x8. We need to request it.
>
> Fixes: 701dc207bf55 ("i2c: piix4: Avoid race conditions with IMC")
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> Please note, not tested on hardware.
> drivers/i2c/busses/i2c-piix4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index e34d82e79b98..73cc6799cc59 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> @@ -58,7 +58,7 @@
> #define SMBSLVDAT (0xC + piix4_smba)
>
> /* count for request_region */
> -#define SMBIOSIZE 8
> +#define SMBIOSIZE 9
>
> /* PCI Address Constants */
> #define SMBBA 0x090
I checked all the datasheets I have access to, and it should be good.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic