[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4
From:       Kevin Hilman <khilman () ti ! com>
Date:       2011-06-30 22:50:19
Message-ID: 874o37djdg.fsf () ti ! com
[Download RAW message or body]

Shubhrajyoti <shubhrajyoti@ti.com> writes:

> On Thursday 30 June 2011 04:53 AM, Kevin Hilman wrote:
>> Shubhrajyoti D<shubhrajyoti@ti.com>  writes:
>>
>>> Currently the fifo depth is set to zero for OMAP4 which disables
>>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>>> on OMAP4 also.
>> Do you know the history of why the FIFO depth was set to zero?  A
>> summary of that history would greatly help reviewers.
>>
>>> Reported-By:Nishanth Menon<nm@ti.com>
>> minor: missing space after ':'
>>
>>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
>> Tested on what platforms?   OMAP3 also?
> OMAP4 and OMAP3

Please add a brief summary of what platforms it was tested on in the
changelog.

>> Could you please rebase this onto my for_3.1/i2c-andy branch[1] where we
>> have a large series of I2C patches queued up for the v3.1 merge window
>> already?
> OK will rebase and resend.

Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]