[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-i2c
Subject: Re: [PATCH 4/7] i2c/pxa2xx: add support for shared IRQ handler
From: Sebastian Andrzej Siewior <bigeasy () linutronix ! de>
Date: 2010-11-25 10:48:30
Message-ID: 4CEE3EFE.2080909 () linutronix ! de
[Download RAW message or body]
Haojian Zhuang wrote:
>> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
>> index dc66fde..7647361 100644
>> --- a/drivers/i2c/busses/i2c-pxa.c
>> +++ b/drivers/i2c/busses/i2c-pxa.c
>> @@ -905,11 +905,17 @@ static void i2c_pxa_irq_rxfull(struct pxa_i2c *i2c, u32 isr)
>> writel(icr, _ICR(i2c));
>> }
>>
>> +#define VALID_INT_SOURCE (ISR_SSD | ISR_ALD | ISR_ITE | ISR_IRF | \
>> + ISR_SAD | ISR_BED)
>> static irqreturn_t i2c_pxa_handler(int this_irq, void *dev_id)
>> {
>> struct pxa_i2c *i2c = dev_id;
>> u32 isr = readl(_ISR(i2c));
>>
>> + isr &= VALID_INT_SOURCE;
>> + if (!isr)
>> + return IRQ_NONE;
>> +
>
> If you return at here, the valid interrupt status event won't be
> cleared in IRQ handler. So I2C interrupt handler will be triggered at
> next time.
The point here is that I have a shared handler and I have to know if my
i2c device issued an interrupt or another device. If I return here then it
was not my i2c device bot some other device hanging on the same interrupt
line.
I can't simply test for !isr (without VALID_INT_SOURCE) because some bits
in this register have nothing todo with the interrupt status as it.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic