[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    [PATCH] i2c/scx200_acb: Provide more information on bus errors
From:       Jean Delvare <khali () linux-fr ! org>
Date:       2009-08-29 19:18:38
Message-ID: 20090829211838.6b6c67fd () hyperion ! delvare
[Download RAW message or body]

From: Willy Tarreau <wtarreau@exceliance.fr>

Upon a bus error, it's rather hard to guess what happened. Dumping the
address, length and status provides a lot of value for troubleshooting
issues.

Signed-off-by: Willy Tarreau <wtarreau@exceliance.fr>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
 drivers/i2c/busses/scx200_acb.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

--- linux-2.6.31-rc8.orig/drivers/i2c/busses/scx200_acb.c	2009-06-10 05:05:27.000000000 +0200
+++ linux-2.6.31-rc8/drivers/i2c/busses/scx200_acb.c	2009-08-29 20:44:33.000000000 +0200
@@ -217,8 +217,10 @@ static void scx200_acb_machine(struct sc
 	return;
 
  error:
-	dev_err(&iface->adapter.dev, "%s in state %s\n", errmsg,
-		scx200_acb_state_name[iface->state]);
+	dev_err(&iface->adapter.dev,
+		"%s in state %s (addr=0x%02x, len=%d, status=0x%02x)\n", errmsg,
+		scx200_acb_state_name[iface->state], iface->address_byte,
+		iface->len, status);
 
 	iface->state = state_idle;
 	iface->result = -EIO;


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]