[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [PATCHv2 2/3] Regulator: Add TPS6507x regulator driver
From:       Mark Brown <broonie () opensource ! wolfsonmicro ! com>
Date:       2009-08-20 18:38:18
Message-ID: 20090820183817.GA5032 () sirena ! org ! uk
[Download RAW message or body]

On Thu, Aug 20, 2009 at 07:20:30PM +0530, Anuj Aggarwal wrote:

One very minor issue:

> +struct tps_pmic {
> +	struct regulator_desc desc[TPS6507X_NUM_REGULATOR];
> +	struct i2c_client *client;
> +	struct regulator_dev *rdev[TPS6507X_NUM_REGULATOR];
> +	struct tps_info *info[TPS6507X_NUM_REGULATOR];

This should be const struct tps_info * since the table of tps_info
structs that this points into is const; otherwise you'll get warnings
from at least sparse.

Otherwise this looks good - I'd be happy to ack this with a followup
patch fixing this issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]