[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [i2c] [PATCH 1/8] i2c-omap: Do not use interruptible wait call
From:       Jarkko Nikula <jarkko.nikula () nokia ! com>
Date:       2008-09-30 11:51:00
Message-ID: 20080930145100.62fdb0fa.jarkko.nikula () nokia ! com
[Download RAW message or body]

On Mon, 29 Sep 2008 23:21:00 +0100
"ext Ben Dooks" <ben-linux@fluff.org> wrote:

> On Thu, Sep 25, 2008 at 10:53:47AM +0300, Tony Lindgren wrote:
> > From: Jarkko Nikula <jarkko.nikula@nokia.com>
> > 
> > If there is a signal pending and wait_for_completion_interruptible_timeout
> > terminates with -ERESTARTSYS, we return and disable the i2c clocks in
> > omap_i2c_xfer.
> > 
> > If we terminate before sending last i2c message with a stop condition, the
> > bus remains busy and we are not able to send new messages into bus with
> > successive omap_i2c_xfer calls. Therefore a pending signal is not caught
> > here and we return only because of timeout or i2c error.
> 
> I assume that this is preferable to aborting an transfer when the
> signal is caught (if possible) ?
>  
Most probably yes as long as the stop condition is generated
successfully. IRCC bug behind this fix, OMAP I2C went into bus
arbitration without code able to recover easily or something like that.

Would it be ok to let this fix as now, probably adding FIXME line near
wait_for_completion_timeout so that we don't break anything now but
note that this is not optimal fix?


Jarkko

_______________________________________________
i2c mailing list
i2c@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
[prev in list] [next in list] [prev in thread] [next in thread]