[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-i2c
Subject:    Re: [i2c] [PATCH] unhide smbus on Compaq Deskpro EN
From:       Jean Delvare <khali () linux-fr ! org>
Date:       2008-05-31 15:13:43
Message-ID: 20080531171343.49dd8ceb () hyperion ! delvare
[Download RAW message or body]

Hi Krzysztof,

On Fri, 30 May 2008 23:21:18 +0200, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
> 
> This patch unhides the smbus on Compaq Deskpro EN
> SFF P667 with the Intel 815E chipset. 
> The patch was tested on Fedora Core 9 with 2.6.25.4 kernel.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
> Tested-by: Rafał Haładuda <rh1985@wp.pl>
> 
> ---
> 
> No side effects were observed. The ACPI controlled fan
> correctly with the patch applied. Tested with 667 and
> 1000 MHz CPUs.
> The patch allows using the THMC51 sensor chip on
> the motherboard.
> The patch was done against the kernel 2.6.26-rc2-mm1

I would like to see the ACPI DSDT of this machine. If ACPI is
controlling the fan then there are good chances that unhiding the SMBus
is the wrong thing to do, even if you did not notice any problem yet.

Thanks,
-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

[prev in list] [next in list] [prev in thread] [next in thread]