[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-hwmon
Subject:    Re: [PATCH] hwmon: (gpio-fan): Switch to using the new API kobj_to_dev()
From:       Guenter Roeck <linux () roeck-us ! net>
Date:       2020-12-30 16:04:43
Message-ID: 20201230160443.GA100576 () roeck-us ! net
[Download RAW message or body]

On Tue, Dec 29, 2020 at 11:17:17AM +0800, Tian Tao wrote:
> fixed the following coccicheck:
> drivers/hwmon/gpio-fan.c:302:60-61: WARNING opportunity for
> kobj_to_dev()
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/gpio-fan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
> index 3ea4021..befe989 100644
> --- a/drivers/hwmon/gpio-fan.c
> +++ b/drivers/hwmon/gpio-fan.c
> @@ -299,7 +299,7 @@ static DEVICE_ATTR(fan1_target, 0644, fan1_input_show, set_rpm);
>  static umode_t gpio_fan_is_visible(struct kobject *kobj,
>  				   struct attribute *attr, int index)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct gpio_fan_data *data = dev_get_drvdata(dev);
>  
>  	if (index == 0 && !data->alarm_gpio)
[prev in list] [next in list] [prev in thread] [next in thread]