[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-hwmon
Subject:    Re: [PATCH] hwmon: (ntc_thermistor): try reading processed
From:       Linus Walleij <linus.walleij () linaro ! org>
Date:       2020-12-24 0:47:38
Message-ID: CACRpkdYJSE_wSf72N=oX+JogdTF-FBSqkeMZghrr1ytmPY8apQ () mail ! gmail ! com
[Download RAW message or body]

On Wed, Dec 23, 2020 at 10:42 PM Guenter Roeck <linux@roeck-us.net> wrote:

> You don't
> answer the basic question: What should the driver do if the iio
> subsystem only delivers raw values ? I suggested we should just keep
> the current assumption in this case, ie do the fixed conversion,
> and let userspace handle any necessary adjustments. You seem to object.
> With your patch, we get a comment in the driver suggesting that some
> code should be removed. In my opinion, such a comment comment does
> not add any value. Ether we drop the code or we don't, and I dislike
> removing it.
>
> That results in my usual fallback: When in doubt, do nothing.

OK I get it, I'll fix it up along with the confused bug pointed out by
Chris and resend.

Thanks!
Linus Walleij
[prev in list] [next in list] [prev in thread] [next in thread]