[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-hardening
Subject:    Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang
From:       Jeffrey E Altman <jaltman () auristor ! com>
Date:       2021-04-21 23:41:56
Message-ID: f843303f-435f-7b37-a717-0026492d5342 () auristor ! com
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]

[Attachment #4 (multipart/mixed)]


On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

This change looks good to me.  Although I would also be happy with a 
fallthrough statement being added instead.

Reviewed-by: Jeffrey Altman <jaltman@auristor.com>


["jaltman.vcf" (text/x-vcard)]
["OpenPGP_signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]