[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-hams
Subject:    [PATCH net 01/12] netrom: Fix a data-race around sysctl_netrom_default_path_quality
From:       Jason Xing <kerneljasonxing () gmail ! com>
Date:       2024-03-04 8:20:35
Message-ID: 20240304082046.64977-2-kerneljasonxing () gmail ! com
[Download RAW message or body]

From: Jason Xing <kernelxing@tencent.com>

We need to protect the reader reading sysctl_netrom_default_path_quality
because the value can be changed concurrently.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
---
 net/netrom/nr_route.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index baea3cbd76ca..6f709fdffc11 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -153,7 +153,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
 		nr_neigh->digipeat = NULL;
 		nr_neigh->ax25     = NULL;
 		nr_neigh->dev      = dev;
-		nr_neigh->quality  = sysctl_netrom_default_path_quality;
+		nr_neigh->quality  = READ_ONCE(sysctl_netrom_default_path_quality);
 		nr_neigh->locked   = 0;
 		nr_neigh->count    = 0;
 		nr_neigh->number   = nr_neigh_no++;
-- 
2.37.3


[prev in list] [next in list] [prev in thread] [next in thread]