[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-hams
Subject:    Re: [PATCH NET 1/7] skbuff: introduce pskb_realloc_headroom()
From:       Vasily Averin <vvs () virtuozzo ! com>
Date:       2021-07-12 18:45:28
Message-ID: 55c9e2ae-b060-baa2-460c-90eb3e9ded5c () virtuozzo ! com
[Download RAW message or body]

On 7/12/21 8:53 PM, Jakub Kicinski wrote:
> I saw you asked about naming in a different sub-thread, what do you
> mean by "'pskb_expand_head' have different semantic"? AFAIU the 'p'
> in pskb stands for "private", meaning not shared. In fact
> skb_realloc_headroom() should really be pskb... but it predates the 
> 'pskb' naming pattern by quite a while. Long story short
> skb_expand_head() seems like a good name. With the current patch
> pskb_realloc_headroom() vs skb_realloc_headroom() would give people
> exactly the opposite intuition of what the code does.

Thank you for feedback,
I'll change helper name back to skb_expand_head() in next patch version.

	Vasily Averin
[prev in list] [next in list] [prev in thread] [next in thread]