[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    [Linux-ha-dev] [PATCH] USE_ROUTE_GET bug
From:       Ragnar_Kjørstad <linux-ha () ragnark ! vestdata ! no>
Date:       2001-07-24 21:41:42
[Download RAW message or body]

Hi

There appear to be a bug in the usage of the USE_ROUTE_GET macro.

The macro is set to "YES" or "NO" by configure, but in findif.c checks
if the macro is defined or not - obviously it's always defined, so the
(broken) "route -n" test is used rather than the (working)
/proc/net/route test.

Maybe the best fix would be to have configure define the macro only when
route -n should be used, or maybe to put the macroes in a config.h
rather than the current Makefile stuff?

Anyway, since I'm not sure what's the prefered fix, I'm suggested the
smallest fix, that is to define USE_ROUTE_GET to 0 or 1, and use #if
instead of #ifdef.

The patch is attached. (note, it also fixes automake for ifconfig. This
fix was also part of my previous compile/build patch, so if you want to
apply both, you should apply this one first, and then ignore the
rejects).



-- 
Ragnar Kjorstad
Big Storage
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.community.tummy.com
http://lists.community.tummy.com/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

[prev in list] [next in list] [prev in thread] [next in thread]