[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] support LSBs /run directory
From:       Lars Ellenberg <lars.ellenberg () linbit ! com>
Date:       2013-12-23 12:58:52
Message-ID: 20131223125852.GQ31214 () soda ! linbit
[Download RAW message or body]

On Fri, Dec 20, 2013 at 12:20:26PM +0100, Timur I. Bakeyev wrote:
> On Wed, Dec 18, 2013 at 2:08 PM, Serge Dubrouski <sergeyfd@gmail.com> wrote:
> 
> > Lars -
> >
> > I'm a bit lost on "path=$varrun/$path". Why do we need to add $varrun if
> > it doesn't present? The goal is to cover the case when /run , or any other
> > directory, is used instead of /var/run

Ignore for a moment that I used the variable name "varrun".

> /run is used instead of /var/run, and /var/run is a symlink to /run. Within
> a distribution RUNDIR is, kind of, hardcoded, no matter what is it.

That's why I used the @@__autofoo_notation__@@ and I'm too lazy to look
up what the correct name between @@ @@ would be; last time I checked,
people where still discussing --rundir, --varrundir, --runstatedir and
others.

Anyways, that's supposed to be the "distribution wide hardcoded default",
and that would be replaced by autofoo/configure at build time of this
package.

I think we have it already in ocf-directories.in as
: ${HA_VARRUN:=@localstatedir@/run/}
and we probably should change that to
: ${HA_RUNSTATEDIR:=@runstatedir@}
(or HA_RUNDIR:=@rundir@; whatever will be the proper autofoo name for it)
and keep the alias
HA_VARRUN=$HA_RUNSTATEDIR

And now, assume that this variable, despite the name,
has a value of /run on those distributions that use /run,
and /var/run on those that use that,
and $home/var/run or $prefix/var/run when people install locally
(not that that'd make much sense for resoruce-agents...)


Ok?

> So real question is to distinct usage of the plain RUNDIR and sub-directory
> under it, as later one requires some special handling on memory based file
> systems.
> 
> 
> With regards,
> Timur Bakeyev.
> 
> 
> 
> 
> > On Tue, Dec 17, 2013 at 1:48 PM, Timur I. Bakeyev <timur@com.bat.ru>wrote:
> >
> >> Hi, Lars!
> >>
> >> On Tue, Dec 17, 2013 at 1:43 PM, Lars Ellenberg <
> >> lars.ellenberg@linbit.com> wrote:
> >>
> >>> On Tue, Dec 17, 2013 at 02:39:52AM +0100, Timur I. Bakeyev wrote:
> >>> > Hi, guys!
> >>> >
> >>> > Any reaction, please?
> >>>
> >>> Probably best to add a helper to ocf-functions, say,
> >>> # require_run_dir <mode> user:group path
> >>> require_run_dir()
> >>> {
> >>>         local mode=$1 owner=$2 path=$3
> >>>         local $varrun=@@__varrun_or_whatever_autofoo_calls_it__@@
> >>>         case $path in
> >>>         $varrun/*)      : nothing ;;
> >>>         *)
> >>>                 path=$varrun/$path ;;
> >>>         esac
> >>>         test -d $path && return 0
> >>>         [ $(id -u) = 0 ] || return 1
> >>>
> >>>         # (or some helper function mkdir_p, in case we doubt -p is
> >>> available...)
> >>>         mkdir -p $path && chown $owner $path && chmod $mode $path
> >>> }
> >>>
> >>>
> >>> Then use that early in the various resource agents,
> >>> maybe where the defaults are defined.
> >>>
> >>> Yes?
> >>>
> >>
> >>
> >> That would be even better! There are few more RAs that would benefit from
> >> that.
> >>
> >> I'd only invert the parameters, as path is mandatory, permissions are
> >> semi-optional and owner, as in 99% we run as root - optional. And I'd put
> >> some meaningful defaults for the later two parameters:
> >>
> >> local path=$1 mode=$2 owner=$3
> >> : ${mode:=0755}
> >> : ${owner:=root}
> >>
> >> Also, as 'path' is usually is smth. like '/var/run/named' or
> >> '/var/run/zabbix' I'm afraid that switch will do nothing in any case.
> >>
> >> need a bit more magic, smth. like:
> >>
> >> if [ -n "${path##$varrun}" ]
> >>
> >> or alike.
> >>
> >> With best regards,
> >> Timur.
> >>
> >>
> >>
> >>
> >>
> >> _______________________________________________________
> >> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> >> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >> Home Page: http://linux-ha.org/
> >>
> >>
> >
> >
> > --
> > Serge Dubrouski.
> >
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> >
> >

> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/


-- 
: Lars Ellenberg
: LINBIT | Your Way to High Availability
: DRBD/HA support and consulting http://www.linbit.com

DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]