[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-ha-dev
Subject: Re: [Linux-ha-dev] pgsql and streaming replcation
From: Serge Dubrouski <sergeyfd () gmail ! com>
Date: 2012-03-18 16:05:34
Message-ID: CADT7cy1HsbO=6bnOdRMCOWK1aADcx6mpywwmGuuQjT-O+JEwQQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I sent a patch to the mail list. It's your RA but in some places I split
long lines into several ones.
On Tue, Mar 13, 2012 at 8:41 PM, Serge Dubrouski <sergeyfd@gmail.com> wrote:
> Takatoshi -
>
> Please give me some time to review the latest version of RA and then we'll
> submit a patch.
>
> On Tue, Mar 13, 2012 at 5:35 AM, Takatoshi MATSUO <matsuo.tak@gmail.com>wrote:
>
>> Hello Serge
>>
>> 2012/3/9 Takatoshi MATSUO <matsuo.tak@gmail.com>:
>> > Hello Serge
>> >
>> > 2012/3/8 Serge Dubrouski <sergeyfd@gmail.com>:
>> >> Hello, Takatoshi -
>> >>
>> >> On one hand this is a good feature to have, but on another if it's not
>> >> stable, fails most of the time and brings to much of complexity to the
>> RA
>> >> then drop it.
>> >> It seems like Andrew has plans to include support for stopping
>> >> resources on demote in the future versions of Pacemaker.
>> >
>> > It's a good news.
>> > I will remove code of restarting for the future.
>> > Please accept a little complexity until future version is released.
>>
>> I removed code of restarting
>> and I reconsider some checks of inconsistency.
>>
>> In this change
>> PGSQL.lock file is created on promote
>> and it's removed on demote only if there is no Slave.
>> And I removed a complex check before start
>> such as checking Timeline ID , Checkpoint
>> because PGSQL.lock can means inconsistency.
>>
>> I want to adopt a serious stance for merging by now.
>> Do you have any other comments ?
>> And what's the first step for merging ?
>>
>> >>
>> >> On Tue, Mar 6, 2012 at 11:43 PM, Takatoshi MATSUO <
>> matsuo.tak@gmail.com>
>> >> wrote:
>> >>>
>> >>> Hi Serge
>> >>>
>> >>> I think about removing code of restarting PostgreSQL on demote.
>> >>> Because almost restarts are failed to avoid data inconsistency.
>> >>> In addition this check is complex.
>> >>> PostgreSQL developer says that this occurrence is specific and
>> >>> can't be fix immediately.
>> >>>
>> >>> What do you think ?
>>
>> Regartds,
>> Takatoshi MTSUO
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
>>
>
>
>
> --
> Serge Dubrouski.
>
--
Serge Dubrouski.
[Attachment #5 (text/html)]
I sent a patch to the mail list. It's your RA but in some places I split long \
lines into several ones.<br><br><div class="gmail_quote">On Tue, Mar 13, 2012 at 8:41 \
PM, Serge Dubrouski <span dir="ltr"><<a \
href="mailto:sergeyfd@gmail.com">sergeyfd@gmail.com</a>></span> wrote:<br> \
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Takatoshi -<br><br>Please give me some time to review the \
latest version of RA and then we'll submit a patch. <br><div class="HOEnZb"> <div \
class="h5"><br><div class="gmail_quote">On Tue, Mar 13, 2012 at 5:35 AM, Takatoshi \
MATSUO <span dir="ltr"><<a href="mailto:matsuo.tak@gmail.com" \
target="_blank">matsuo.tak@gmail.com</a>></span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hello Serge<br> <br>
2012/3/9 Takatoshi MATSUO <<a href="mailto:matsuo.tak@gmail.com" \
target="_blank">matsuo.tak@gmail.com</a>>:<br> <div>> Hello Serge<br>
><br>
> 2012/3/8 Serge Dubrouski <<a href="mailto:sergeyfd@gmail.com" \
target="_blank">sergeyfd@gmail.com</a>>:<br> >> Hello, Takatoshi -<br>
>><br>
>> On one hand this is a good feature to have, but on another if it's \
not<br> >> stable, fails most of the time and brings to much of complexity to \
the RA<br> >> then drop it.<br>
>> It seems like Andrew has plans to include support for stopping<br>
>> resources on demote in the future versions of Pacemaker.<br>
><br>
> It's a good news.<br>
> I will remove code of restarting for the future.<br>
> Please accept a little complexity until future version is released.<br>
<br>
</div>I removed code of restarting<br>
and I reconsider some checks of inconsistency.<br>
<br>
In this change<br>
PGSQL.lock file is created on promote<br>
and it's removed on demote only if there is no Slave.<br>
And I removed a complex check before start<br>
such as checking Timeline ID , Checkpoint<br>
because PGSQL.lock can means inconsistency.<br>
<br>
I want to adopt a serious stance for merging by now.<br>
Do you have any other comments ?<br>
And what's the first step for merging ?<br>
<div><br>
>><br>
>> On Tue, Mar 6, 2012 at 11:43 PM, Takatoshi MATSUO <<a \
href="mailto:matsuo.tak@gmail.com" target="_blank">matsuo.tak@gmail.com</a>><br> \
>> wrote:<br> >>><br>
>>> Hi Serge<br>
>>><br>
>>> I think about removing code of restarting PostgreSQL on demote.<br>
>>> Because almost restarts are failed to avoid data inconsistency.<br>
>>> In addition this check is complex.<br>
>>> PostgreSQL developer says that this occurrence is specific and<br>
>>> can't be fix immediately.<br>
>>><br>
>>> What do you think ?<br>
<br>
</div>Regartds,<br>
Takatoshi MTSUO<br>
<div><div>_______________________________________________________<br>
Linux-HA-Dev: <a href="mailto:Linux-HA-Dev@lists.linux-ha.org" \
target="_blank">Linux-HA-Dev@lists.linux-ha.org</a><br> <a \
href="http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev" \
target="_blank">http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev</a><br> Home \
Page: <a href="http://linux-ha.org/" target="_blank">http://linux-ha.org/</a><br> \
</div></div></blockquote></div><br><br clear="all"><br></div></div><span \
class="HOEnZb"><font color="#888888">-- <br>Serge Dubrouski.<br> \
</font></span></blockquote></div><br><br clear="all"><br>-- <br>Serge Dubrouski.<br>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic