[prev in list] [next in list] [prev in thread] [next in thread]
List: linux-ha-dev
Subject: Re: [Linux-ha-dev] OCF RA for named
From: Serge Dubrouski <sergeyfd () gmail ! com>
Date: 2011-09-20 1:26:02
Message-ID: CADT7cy2F86TbxcFpFFLbzFw1Anm97xHE6pG23+uS=OgHowCp0A () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Mon, Sep 19, 2011 at 9:33 AM, Dejan Muhamedagic <dejan@suse.de> wrote:
> On Mon, Sep 19, 2011 at 04:10:50PM +0200, Dejan Muhamedagic wrote:
> > On Tue, Sep 06, 2011 at 02:52:47PM -0600, Serge Dubrouski wrote:
> > > On Thu, Sep 1, 2011 at 6:28 AM, Dejan Muhamedagic <dejan@suse.de>
> wrote:
> > >
> > [...]
> > > > > <parameter name="monitor_ip" unique="0" required="0">
> > > > > <longdesc lang="en">
> > > > > IP Address where named listens.
> > > > > </longdesc>
> > > > > <shortdesc lang="en">monitor_ip</shortdesc>
> > > > > <content type="string" default="${OCF_RESKEY_monitor_ip_default}"
> />
> > > > > </parameter>
> > > > > </parameters>
> > > >
> > > > Why not just use localhost? Could there be an instance which
> > > > doesn't listen on the lo interface?
> > > >
> > >
> > > Disagree. I usually prefer monitor clustered resources through VIPs
> they
> > > assigned to. Also localhost wouldn't work with the case of several
> instances
> > > listening on different interfaces.
> >
> > OK.
> >
> > [...]
> > > > > if [ -z "$OCF_RESKEY_monitor_request" -o \
> > > > > -z "$OCF_RESKEY_monitor_response" -o \
> > > > > -z "$OCF_RESKEY_monitor_ip" ]; then
> > > > > ocf_log err "Neither monitor_request, monitor_response or
> > > > monitor_ip can be empty"
> > > >
> > > > ocf_log err "Neither monitor_request, monitor_response, nor
> monitor_ip can
> > > > be empty"
> > > >
> > > > (I guess, not a native speaker.)
> > > >
> > >
> > > Even after 10 years of living in the US. Next time will check with my
> > > daughter ;-)
> >
> > Actually, I was wrong too. "Neither" can be used just for two
> > things, not three or more. In this case, it should be:
> >
> > ocf_log err "None of monitor_request, monitor_response, and monitor_ip
> can
> > be empty"
> >
> > I'll fix that before check-in.
>
> OT:
>
> Well, it turns out that I wasn't so wrong after all, just need
> to remove the comma:
>
> ocf_log err "Neither monitor_request, monitor_response nor monitor_ip can
> be empty"
>
> But the "None" variety still sounds better to me.
>
> Cheers,
>
Thanks.
>
> Dejan
>
> > Many thanks for the contribution!
> >
> > Cheers,
> >
> > Dejan
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>
--
Serge Dubrouski.
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">On Mon, Sep 19, 2011 at 9:33 AM, Dejan Muhamedagic \
<span dir="ltr"><<a href="mailto:dejan@suse.de">dejan@suse.de</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div><div></div><div \
class="h5">On Mon, Sep 19, 2011 at 04:10:50PM +0200, Dejan Muhamedagic wrote:<br> \
> On Tue, Sep 06, 2011 at 02:52:47PM -0600, Serge Dubrouski wrote:<br> > > \
On Thu, Sep 1, 2011 at 6:28 AM, Dejan Muhamedagic <<a \
href="mailto:dejan@suse.de">dejan@suse.de</a>> wrote:<br> > ><br>
> [...]<br>
> > > > <parameter name="monitor_ip" unique="0" \
required="0"><br> > > > > <longdesc \
lang="en"><br> > > > > IP Address where named listens.<br>
> > > > </longdesc><br>
> > > > <shortdesc \
lang="en">monitor_ip</shortdesc><br> > > > > \
<content type="string" \
default="${OCF_RESKEY_monitor_ip_default}" /><br> > > > > \
</parameter><br> > > > > </parameters><br>
> > ><br>
> > > Why not just use localhost? Could there be an instance which<br>
> > > doesn't listen on the lo interface?<br>
> > ><br>
> ><br>
> > Disagree. I usually prefer monitor clustered resources through VIPs \
they<br> > > assigned to. Also localhost wouldn't work with the case of \
several instances<br> > > listening on different interfaces.<br>
><br>
> OK.<br>
><br>
> [...]<br>
> > > > if [ -z "$OCF_RESKEY_monitor_request" -o \<br>
> > > > -z "$OCF_RESKEY_monitor_response" -o \<br>
> > > > -z "$OCF_RESKEY_monitor_ip" ]; then<br>
> > > > ocf_log err "Neither monitor_request, \
monitor_response or<br> > > > monitor_ip can be empty"<br>
> > ><br>
> > > ocf_log err "Neither monitor_request, monitor_response, nor \
monitor_ip can<br> > > > be empty"<br>
> > ><br>
> > > (I guess, not a native speaker.)<br>
> > ><br>
> ><br>
> > Even after 10 years of living in the US. Next time will check with my<br>
> > daughter ;-)<br>
><br>
> Actually, I was wrong too. "Neither" can be used just for two<br>
> things, not three or more. In this case, it should be:<br>
><br>
> ocf_log err "None of monitor_request, monitor_response, and monitor_ip \
can<br> > be empty"<br>
><br>
> I'll fix that before check-in.<br>
<br>
</div></div>OT:<br>
<br>
Well, it turns out that I wasn't so wrong after all, just need<br>
to remove the comma:<br>
<div class="im"><br>
ocf_log err "Neither monitor_request, monitor_response nor monitor_ip can be \
empty"<br> <br>
</div>But the "None" variety still sounds better to me.<br>
<br>
Cheers,<br></blockquote><div><br>Thanks.<br> <br></div><blockquote \
class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, \
204, 204); padding-left: 1ex;"> <font color="#888888"><br>
Dejan<br>
</font><div><div></div><div class="h5"><br>
> Many thanks for the contribution!<br>
><br>
> Cheers,<br>
><br>
> Dejan<br>
> _______________________________________________________<br>
> Linux-HA-Dev: <a \
href="mailto:Linux-HA-Dev@lists.linux-ha.org">Linux-HA-Dev@lists.linux-ha.org</a><br> \
> <a href="http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev" \
target="_blank">http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev</a><br> > \
Home Page: <a href="http://linux-ha.org/" \
target="_blank">http://linux-ha.org/</a><br> \
_______________________________________________________<br>
Linux-HA-Dev: <a href="mailto:Linux-HA-Dev@lists.linux-ha.org">Linux-HA-Dev@lists.linux-ha.org</a><br>
<a href="http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev" \
target="_blank">http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev</a><br> Home \
Page: <a href="http://linux-ha.org/" target="_blank">http://linux-ha.org/</a><br> \
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Serge Dubrouski.<br>
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic