[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] endian oddity in cluster glue
From:       Pádraig Brady <P () draigBrady ! com>
Date:       2011-09-16 16:04:21
Message-ID: 4E737385.8000708 () draigBrady ! com
[Download RAW message or body]

On 09/05/2011 04:02 PM, Pádraig Brady wrote:
> I was looking at extricating some logic from cluster-glue-libs
> and noticed strangeness wrt the endianess checking.
> CONFIG_BIG_ENDIAN is defined on my x86 machine, which is
> due to configure.ac referencing a non existent byteorder_test.c
> 
> To fix this I would suggest the following patch.
> However, I'm wary that this may introduce compatibility
> issues with generated md5 sums which is the only code
> that inspects the above defines.  If we stick with BIG_ENDIAN
> always then there will be interoperability issues between
> x86 and ppc hosts for example (which may not be an issue)?

Actually the code invoked to swap on little endian machines
turns out to be an expensive NOOP. Hence the patch (which
I'm sending separately from hg), is valid and just a cleanup
and on little endian machines a performance improvement.
There should be no functional difference.

cheers,
Pádraig.
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

[prev in list] [next in list] [prev in thread] [next in thread]