[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] CRM: Add warning if start or stop
From:       Dejan Muhamedagic <dejanmm () fastmail ! fm>
Date:       2011-03-09 12:42:18
Message-ID: 20110309124217.GE32317 () rondo ! homenet
[Download RAW message or body]

On Wed, Mar 09, 2011 at 01:29:27PM +0100, Federica Teodori wrote:
> Hi Dejan, 
> 
> > Thanks for the patch, but can you please repost as an attachment.
> > The mail agent did the reformatting :)
> 
> There you go, and apologies for the mess.

No problems. Applied. Thanks again for the patch.

Cheers,

Dejan

> Bye, 
> Federica

> From ea6b27b7200705e798f0b5d0e76e3d6e0d5dbf4f Mon Sep 17 00:00:00 2001
> From: Federica Teodori <federica.teodori@googlemail.com>
> Date: Wed, 9 Mar 2011 12:47:09 +0100
> Subject: [PATCH] Add warning if start or stop interval is not zero
> 
> ---
> shell/modules/ra.py.in |    5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/shell/modules/ra.py.in b/shell/modules/ra.py.in
> index a7b3c3e..022f767 100644
> --- a/shell/modules/ra.py.in
> +++ b/shell/modules/ra.py.in
> @@ -479,6 +479,11 @@ class RAInfo(object):
> common_warn("%s: action %s not advertised in meta-data, it may not be supported by \
> the RA" % (id,op)) rc |= 1
> continue
> +	    if "interval" in n_ops[op]:
> +                if n_ops[op]["interval"] != "0":
> +                    if op == "start" or op == "stop":
> +                        v = n_ops[op]["interval"]
> +                        common_warn("%s: Specified interval for %s is %s, this is \
> greater than 0 thus invalid" %(id,op,v)) try:
> adv_timeout = self.actions()[op]["timeout"]
> except:
> -- 
> 1.7.3.4
> 

> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


[prev in list] [next in list] [prev in thread] [next in thread]