[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] ocft: status vs. monitor
From:       Dejan Muhamedagic <dejanmm () fastmail ! fm>
Date:       2011-02-14 11:06:42
Message-ID: 20110214110641.GA8927 () rondo ! homenet
[Download RAW message or body]

On Sun, Feb 13, 2011 at 11:01:44AM +0100, Holger Teutsch wrote:
> Hi,
> to my knowledge OCF *requires* a method monitor while status is optional
> (or what is it really for? heritage, compatibility, ...)

Yes, patch applied.

Cheers,

Dejan

> Shouldn't the ocft configs check for status ?
> 
> -holger
> 
> diff -r 722c8a7a03e9 tools/ocft/apache
> --- a/tools/ocft/apache	Fri Feb 11 18:49:09 2011 +0100
> +++ b/tools/ocft/apache	Sun Feb 13 10:57:50 2011 +0100
> @@ -52,14 +52,14 @@
>  	Include prepare
>  	AgentRun stop OCF_SUCCESS
>  
> -CASE "running status"
> +CASE "running monitor"
>  	Include prepare
>  	AgentRun start
> -	AgentRun status OCF_SUCCESS
> +	AgentRun monitor OCF_SUCCESS
>  
> -CASE "not running status"
> +CASE "not running monitor"
>  	Include prepare
> -	AgentRun status OCF_NOT_RUNNING
> +	AgentRun monitor OCF_NOT_RUNNING
>  
>  CASE "unimplemented command"
>  	Include prepare
> diff -r 722c8a7a03e9 tools/ocft/mysql
> --- a/tools/ocft/mysql	Fri Feb 11 18:49:09 2011 +0100
> +++ b/tools/ocft/mysql	Sun Feb 13 10:57:50 2011 +0100
> @@ -46,14 +46,14 @@
>  	Include prepare
>  	AgentRun stop OCF_SUCCESS
>  
> -CASE "running status"
> +CASE "running monitor"
>  	Include prepare
>  	AgentRun start
> -	AgentRun status OCF_SUCCESS
> +	AgentRun monitor OCF_SUCCESS
>  
> -CASE "not running status"
> +CASE "not running monitor"
>  	Include prepare
> -	AgentRun status OCF_NOT_RUNNING
> +	AgentRun monitor OCF_NOT_RUNNING
>  
>  CASE "check lib file"
>  	Include prepare
> 
> 
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]