[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] Low: SAPInstance: remove unnecessary
From:       alexander.krauth () basf ! com
Date:       2011-01-24 9:37:25
Message-ID: OF177CF0C1.89EDC7F6-ONC1257822.00342BAD-C1257822.0034DF0D () basf-c-s ! be
[Download RAW message or body]

Lars Ellenberg schrieb am 19.01.2011 16:52:56:
> On Wed, Jan 19, 2011 at 12:17:15PM +0100, Dejan Muhamedagic wrote:
> > On Wed, Jan 19, 2011 at 01:49:03AM +0100, Lars Ellenberg wrote:
> > > On Tue, Jan 18, 2011 at 12:15:03PM +0100, Dejan Muhamedagic wrote:
> > > > On Fri, Jan 14, 2011 at 06:07:44PM +0100, Alexander Krauth wrote:
> > > > > # HG changeset patch
> > > > > # User Alexander Krauth <linux@sap.com>
> > > > > # Date 1295024363 -3600
> > > > > # Node ID 7b76bfaf99e1791c9464aa53520ef20fce0a2356
> > > > > # Parent  267ac174f72d7bfa9b98f573f2a8326ca53df0c2
> > > > > Low: SAPInstance: remove unnecessary usage of eval to start 
processes
> > > > > 
> > > > > diff -r 267ac174f72d -r 7b76bfaf99e1 heartbeat/SAPInstance
> > > > > --- a/heartbeat/SAPInstance   Fri Jan 14 09:41:01 2011 +0100
> > > > > +++ b/heartbeat/SAPInstance   Fri Jan 14 17:59:23 2011 +0100
> > > > > @@ -448,7 +448,7 @@
> > > > >      if have_binary "$VALUE"
> > > > >      then
> > > > >        ocf_log info "Calling userexit ${NAME} with customer 
script file ${VALUE}"
> > > > > -      eval "$VALUE" >/dev/null 2>&1
> > > > > +      $VALUE >/dev/null 2>&1
> > > 
> > > No.
> > > 
> > > Again you are executing something different than you checked for.
> > > 
> > > if you do have_binary "$VALUE",
> > > you likely want to do "$VALUE", not $VALUE.
> > 
> > There should be no difference in this case, right?
> 
> VALUE="/my/stupid whitespace containing/full/path to the/binary or 
script"
> if test -x "$VALUE"; then
>    $VALUE
> fi
> xyz: /my/stupid: No such file or directory
> 
> (just saying)
> 

Ok, I just did send a path for that one.
I also did finish testing the two SAP agents in my environment.
Tests where based on:
SAP 7.30 ABAP + Oracle 11g
SAP 7.20 Java + DB/2 9.7
SAP 7.00 ABAP + MaxDB 7.8

IMO the both agents are good for release now. Except someone of you will 
find more to fix.
Further enhancements of SAPDatabase will follow, as soon as the sapdbctrl 
tools get's the necassary features. But the developer at SAP said last 
week, it will take at least some more weeks. So properly nothing for the 
next release of cluster resource agents.

Cheers
Alex

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]