[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] [PATCH]: Medium: SAPDatabase: Avoid
From:       Dejan Muhamedagic <dejanmm () fastmail ! fm>
Date:       2011-01-18 11:11:44
Message-ID: 20110118111144.GD16000 () rondo ! homenet
[Download RAW message or body]

Hi,

On Fri, Jan 14, 2011 at 06:07:37PM +0100, alexander.krauth@basf.com wrote:
> Lars Ellenberg schrieb am 14.01.2011 11:09:36:
> > On Fri, Jan 14, 2011 at 09:41:10AM +0100, Alexander Krauth wrote:
> > > # HG changeset patch
> > > # User Alexander Krauth <linux@sap.com>
> > > # Date 1294994461 -3600
> > > # Node ID 267ac174f72d7bfa9b98f573f2a8326ca53df0c2
> > > # Parent  f87ea003a238810f523effeec4b60205d82abe82
> > > [PATCH]: Medium: SAPDatabase: Avoid continiuous output to syslog in 
> monitor with SAP 7.20 and J2EE_ONLY=1
> > > 
> > > diff -r f87ea003a238 -r 267ac174f72d heartbeat/SAPDatabase
> > > --- a/heartbeat/SAPDatabase   Tue Jan 11 11:50:33 2011 +0100
> > > +++ b/heartbeat/SAPDatabase   Fri Jan 14 09:41:01 2011 +0100
> > > @@ -129,7 +129,7 @@
> > >    <content type="string" default="" />
> > >   </parameter>
> > >   <parameter name="DB_JARS" unique="1" required="0">
> > > -  <longdesc lang="en">The full qualified filename of the jdbc driver 
> for the database connection test. It will be automaticaly read from the 
> bootstrap.properties file in Java engine 6.40 and 7.
> > 00. For Java engine 7.10 the parameter is mandatory.</longdesc>
> > > +  <longdesc lang="en">The full qualified filename of the jdbc driver 
> for the database connection test. It will be automaticaly read from the 
> bootstrap.properties file in Java engine 6.40 and 7.
> > 00. For Java engine 7.10 and higher the parameter is 
> mandatory.</longdesc>
> > >    <shortdesc lang="en">file name of the jdbc driver</shortdesc>
> > >    <content type="string" default="" />
> > >   </parameter>
> > > @@ -705,7 +705,7 @@
> > > 
> > >        if [ -n "$EXECMD" ]
> > >        then
> > > -        output=`eval ${JAVA_HOME}/bin/java -cp $MYCP $EXECMD`
> > > +        output=`eval ${JAVA_HOME}/bin/java -cp $MYCP $EXECMD 2> 
> /dev/null`
> > 
> > Why does this use eval, at all?
> > 
> > I think using eval there is at least a bug, and may be a security 
> concern,
> > depending on policy of what administrators of the cluster configuration
> > are allowed to do.
> > 
> > Same in
> > sapuserexit() {
> >   NAME="$1"
> >   VALUE="$2"
> > 
> >   if [ -n "$VALUE" ]
> >   then
> >     if [ -x "$VALUE" ]
> >     then
> >       ocf_log info "Calling userexit ${NAME} with customer script file 
> ${VALUE}"
> >       eval "$VALUE" >/dev/null 2>&1
> > 
> > depending on the exact value of $VALUE, this eval will execute something
> > different from what you just test -x 'ed.  So that eval has to go there, 
> too.
> > 
> > Both in SAPDatabase and in SAPInstance.
> 
> You are right. I remember that this came from some SAP start scripts. But 
> I also can't see any advantage of this.
> 
> Please apply this patch to SAPDatabase first. I'll send the patches to 
> remove the eval's based on this one.

Applied.

Cheers,

Dejan

> Regards,
> Alex
> 
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]