[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] About external/riloe
From:       Yoshihiko SATO <satoyoshi () intellilink ! co ! jp>
Date:       2010-09-15 8:48:42
Message-ID: 4C90886A.3060308 () intellilink ! co ! jp
[Download RAW message or body]

Hi, Dejan

Thank you for reply.

I confirmed the revision.
http://hg.linux-ha.org/glue/rev/856e8c18d596

I will confirm it when there is a revision again.
Thanks,

Yoshihiko SATO

(2010/09/14 19:01), Dejan Muhamedagic wrote:
> Hi,
>
> On Mon, Sep 13, 2010 at 03:00:43PM +0900, Yoshihiko SATO wrote:
>> Hi,
>>
>> For external/riloe, I noticed the following.
>>
>> * syntax error
>> ----------
>> [root@srv01 ~]# /usr/lib64/stonith/plugins/external/riloe getconfignames
>>    File "/usr/lib64/stonith/plugins/external/riloe", line 389
>>      for reply in result:
>>                         ^
>> SyntaxError: invalid syntax
>> ----------
>>
>> I want you to apply the following.
>>
>> diff -r /usr/lib64/stonith/plugins/external/riloe /usr/lib64/stonith/plugins/external/riloe.org
>> 388c388
>> <          fatal("no response from %s within %0.2f s"%(rihost,(t_end-t_begin)))
>> ---
>>>          fatal("no response from %s within %0.2f s"%(rihost,(t_end-t_begin))
>
> Thanks for spotting this.
>
>>
>> * ssl module
>> ----------
>> [root@srv01 ~]# /usr/lib64/stonith/plugins/external/riloe
>> Traceback (most recent call last):
>>    File "/usr/lib64/stonith/plugins/external/riloe", line 40, in ?
>>      import ssl
>> ImportError: No module named ssl
>>
>> [root@srv01 ~]# python
>> Python 2.4.3 (#1, Jun 11 2009, 14:09:37)
>> [GCC 4.1.2 20080704 (Red Hat 4.1.2-44)] on linux2
>> Type "help", "copyright", "credits" or "license" for more information.
>>>>> import ssl
>> Traceback (most recent call last):
>>    File "<stdin>", line 1, in ?
>> ImportError: No module named ssl
>> ----------
>>
>> I'm using RHEL5.5.
>> The version of the python is 2.4.3 that is default.
>> The ssl module doesn't exist normally in python 2.4.
>> Because ImportError occurs, the riloe plug-in cannot be used.
>> The downward compatibility to less than python 2.5 is
>> necessary, what do you think?
>
> The ssl module is imported to support the new http proxy
> functionality. I moved the import statement over there now.  If
> Jochen is listening, perhaps ssl could be made optional. Or we
> should switch to another method and replace (iloproxyhost,
> iloproxyport) with iloproxyurl.
>
> Cheers,
>
> Dejan
>
>> Regards,
>> Yoshihiko SATO
>> _______________________________________________________
>> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
>> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
>> Home Page: http://linux-ha.org/
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
>

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]