[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] route del in IPaddr RA
From:       Dejan Muhamedagic <dejanmm () fastmail ! fm>
Date:       2009-11-10 9:55:08
Message-ID: 20091110095457.GA30876 () rondo ! homenet
[Download RAW message or body]

Hi Junko-san,

On Tue, Nov 10, 2009 at 05:45:55PM +0900, Junko IKEDA wrote:
> Hi Dejan,
> 
> >Won't this part be too verbose?
> 
> At first I think so too,
> but ping command doesn't log any messages to ha-log if it succeed.
> 
> >@@ -717,7 +719,7 @@ ip_monitor() {
> >
> >     PINGARGS="`pingargs $OCF_RESKEY_ip`"
> >	      for j in 1 2 3 4 5 6 7 8 9 10; do
> >		  -       if $PING $PINGARGS >/dev/null 2>&1 ; then
> >		  +       if $PING $PINGARGS ; then
> >
> 
> By the way, this is an alternative.
> 
> @@ -717,11 +719,13 @@ ip_monitor() {
> 
>      PINGARGS="`pingargs $OCF_RESKEY_ip`"
>      for j in 1 2 3 4 5 6 7 8 9 10; do
> -       if $PING $PINGARGS >/dev/null 2>&1 ; then
> -           return $OCF_SUCCESS
> -       fi
> +        MSG=`$PING $PINGARGS 2>&1`
> +        if [ $? = 0 ]; then
> +            return $OCF_SUCCESS
> +        fi
>      done
> -
> +
> +    ocf_log err "$MSG"
>      return $OCF_ERR_GENERIC
>  }

Alternative accepted :)

Patch applied.

Cheers,

Dejan

> Thanks,
> Junko
> 
> 
> >>On Mon, 09 Nov 2009 18:13:29 +0900, Junko IKEDA
> >><ikedaj@intellilink.co.jp> wrote:
> >>
> >>>Hi,
> >>>
> >>>I wonder why IPaddr RA needs to run "route del" before it deletes the
> >>>target interface.
> >>>Does the old version of IPaddr contain "route add"?
> >>>
> >>>If "route del" fails, RA will be able to return $OCF_SUCCESS,
> >>>but I feel a little strange when I see the error message from route
> >>>command like this.
> >>>
> >>>lrmd[2576]: 2009/11/09_17:24:08 info: RA output:
> >>>(prmIpPostgreSQLDB:stop:stderr) SIOCDELRT: No such process
> >>>
> >>>Please see the attached file. (IPaddr-1.patch)
> >>>
> >>>It might be possible to delete that line if LVS configuration
> >>>doesn't also
> >>>need it.
> >>>See IPaddr-2.patch. Is it overkill?
> >>>
> >>>Thanks,
> >>>Junko
> >
> >
> >>_______________________________________________________
> >>Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> >>http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >>Home Page: http://linux-ha.org/
> >
> >_______________________________________________________
> >Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> >http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> >Home Page: http://linux-ha.org/


> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/

_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]