[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] add log_level and keepalive
From:       Dejan Muhamedagic <dejanmm () fastmail ! fm>
Date:       2009-09-08 15:41:53
Message-ID: 20090908154153.GE15784 () rondo ! homenet
[Download RAW message or body]

Hi,

On Tue, Sep 08, 2009 at 02:50:09PM +0200, Raoul Bhatia [IPAX] wrote:
> On 09/08/2009 01:03 PM, Dejan Muhamedagic wrote:
> > log_level. And the regular expression test for the same parameter.
> > 
> > Also, log_level set to empty cannot be distinguished from
> > log_level not set at all using grep(1) or test(1). You either
> > have to find another way or change the usage. That is, unless
> > setting --log-level="" is equal to not specifying the --log-level
> > option at all in which case this won't result in a regression.
> 
> i first test for "^(error|warning|info|message|debug)$" which means

It's actually "^(error|warning|info|message|debug|)$"

> that loglevel="" passes this test. it is ok to specify no log-level.

Right.

> before starting i check:
> >     # set log-level
> >     if [ ! -z "$log_level" ]; then
> >         PARAM_PREFIX="$PARAM_PREFIX --log-level=$log_level "
> >     fi
> 
> which should handle this an empty loglevel, right?

Yes, but I thought that you wanted to append --log-level="",
right? Or is that the same as leaving the option out? If so, then
you don't need all this, because it boils down to not specifying
the parameter. Hmm, I wonder if all this sounds too confusing.
The point is just if "mysql-proxy ... --log-level=" is different
from "mysql-proxy ...".

Cheers,

Dejan


> 
> thanks,
> raoul
> -- 
> ____________________________________________________________________
> DI (FH) Raoul Bhatia M.Sc.          email.          r.bhatia@ipax.at
> Technischer Leiter
> 
> IPAX - Aloy Bhatia Hava OEG         web.          http://www.ipax.at
> Barawitzkagasse 10/2/2/11           email.            office@ipax.at
> 1190 Wien                           tel.               +43 1 3670030
> FN 277995t HG Wien                  fax.            +43 1 3670030 15
> ____________________________________________________________________
> _______________________________________________________
> Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
> http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
[prev in list] [next in list] [prev in thread] [next in thread]