[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ha-dev
Subject:    Re: [Linux-ha-dev] [PATCH] IPv6addr: Support a parameter to
From:       Dejan Muhamedagic <dejanmm () fastmail ! fm>
Date:       2009-08-12 12:17:44
Message-ID: 20090812121743.GA10677 () rondo ! homenet
[Download RAW message or body]

Hi Kazunori-san,

On Thu, Aug 06, 2009 at 06:49:19PM +0900, Kazunori INOUE wrote:
> Hi Andre,
> 
> Andre, Pascal wrote:
> > Now, would it be possible to declare IPv6 addresses in the same way ?
> > Ex: IPv6addr::3ffe:1111:2222:3333:4444:5556:6666:7777/64/eth0
> 
> The /etc/ha.d/resource.d/IPv6addr script is changed and it enabled it to
> declare. See attached new patch.
> The IPv6addr script splits the argument into pieces that IPv6addr OCF RA
> can recognize, and sets it to the following environment variable.
> And IPv6addr OCF RA is called.
> * OCF_RESKEY_ipv6addr (Ex: 3ffe:1111:2222:3333:4444:5556:6666:7777)
> * OCF_RESKEY_cidr_netmask (Ex: 64)
> * OCF_RESKEY_nic (Ex: eth0)
> 
> And a new parameter cidr_netmask to specify the netmask was added.
> Now, a v2 user can specify ipv6addr, cidr_netmask, and nic with instance
> parameters.
> It has left the method of old specification of the ipv6addr
> parameter(<ip>/<prefix-len>).
> However, when cidr_netmask is specified, the value of cidr_netmask is used
> as prefix-len.

Applied.

Many thanks for the patch. And to Andre of course for his initial
effort.

Cheers,

Dejan

> For example:
> 
> ### example(1) ###
> <primitive id="ip1:1" class="ocf" type="IPv6addr" provider="heartbeat">
> <operations>
> ...snip...
> </operations>
> <instance_attributes id="ip1:1:attr">
> <attributes>
> <nvpair id="ip01" name="ipv6addr" value="2001:db8:90::189"/>
> <nvpair id="ip02" name="cidr_netmask" value="64"/>
> <nvpair id="ip03" name="nic" value="eth0"/>
> </attributes>
> </instance_attributes>
> </primitive>
> 
> In this case, netmask (prefix-len) is 64.
> 
> ### example(2) ###
> <primitive id="ip1:1" class="ocf" type="IPv6addr" provider="heartbeat">
> <operations>
> ...snip...
> </operations>
> <instance_attributes id="ip1:1:attr">
> <attributes>
> <nvpair id="ip01" name="ipv6addr" value="2001:db8:90::189/24"/>
> <nvpair id="ip02" name="cidr_netmask" value="64"/>
> <nvpair id="ip03" name="nic" value="eth0"/>
> </attributes>
> </instance_attributes>
> </primitive>
> 
> Also in this case, netmask (prefix-len) is 64.
> 
> ### example(3) ###
> <primitive id="ip1:1" class="ocf" type="IPv6addr" provider="heartbeat">
> <operations>
> ...snip...
> </operations>
> <instance_attributes id="ip1:1:attr">
> <attributes>
> <nvpair id="ip01" name="ipv6addr" value="2001:db8:90::189/24"/>
> <nvpair id="ip03" name="nic" value="eth0"/>
> </attributes>
> </instance_attributes>
> </primitive>
> 
> In this case, netmask (prefix-len) is 24.
> 
> We would like to hear any opinion about this.
> 
> 
> Best Regards,
> Kazunori INOUE
> 
> 
> Andre, Pascal wrote:
> > Hi Kazunori-san,
> > 
> > Eventhough I know that backward compatibility with Linux-HA v1 may not be the \
> > most important issue, is your modification compatible with v1 ? In other words, \
> > how can a v1 user declare the 'nic' to be used for IPv6 addresses ? 
> > For IPv4, a v1 user had to declare its IP address as follows: \
> > <ip>/<prefix-len>/<interface> (ex: 135.9.8.7/24/eth0). 
> > Now, would it be possible to declare IPv6 addresses in the same way ?
> > Ex: IPv6addr::3ffe:1111:2222:3333:4444:5556:6666:7777/64/eth0
> > 
> > That's what was done in the patch I proposed a few months ago (the patch you link \
> > to in your mail). Unfortunately, it appeared that my patch was too 'v1 oriented' \
> > ;) and Dejan asked me to add v2 support before re-submitting it. I had a look at \
> > what to do for this, without success (I'm quite a newbie about Linux-HA). Without \
> > more time to devote on this issue, I put it aside. I'm glad you raised the issue \
> > again ;). Now, I would be very thankful if your patch could fix this problem for \
> > v1 users too (unless it does it already). Maybe a solution could be to allow both \
> > ways to add the 'nic': via the parameter 'nic' or by appending it at the end the \
> > IPv6 address string. What do you think ? 
> > Thanks and regards
> > 
> > Pascal ANDRE
> > 
> > 
> > > -----Original Message-----
> > > From: linux-ha-dev-bounces at lists.linux-ha.org
> > > [mailto:linux-ha-dev-bounces at lists.linux-ha.org] On Behalf Of
> > > Kazunori INOUE
> > > Sent: Tuesday, August 04, 2009 2:54 AM
> > > To: linux-ha-dev at lists.linux-ha.org
> > > Cc: shimazakik at intellilink.co.jp
> > > Subject: [Linux-ha-dev] [PATCH] IPv6addr: Support a parameter
> > > to specify interface name
> > > 
> > > Hi lists,
> > > 
> > > I implemented a function to IPv6addr.
> > > I'd like to explain the role of attached patch.
> > > It's for changeset:cf020d609b57.
> > > And it's to add a new parameter "nic" to specify interface.
> > > I referred to Dejan's opinion
> > > (http://www.gossamer-threads.com/lists/linuxha/dev/55234).
> > > 
> > > I would like to hear your opinions.
> > > 
> > > Best Regards,
> > > Kazunori INOUE
> > > 
> > _______________________________________________________
> > Linux-HA-Dev: Linux-HA-Dev at lists.linux-ha.org
> > http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
> > Home Page: http://linux-ha.org/
_______________________________________________________
Linux-HA-Dev: Linux-HA-Dev@lists.linux-ha.org
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/


[prev in list] [next in list] [prev in thread] [next in thread]